[1.0.4] Advance fork db root when pending lib greater than head #1009
+15
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note:start |
greg7mdp
reviewed
Nov 4, 2024
greg7mdp
approved these changes
Nov 4, 2024
greg7mdp
approved these changes
Nov 4, 2024
linh2931
approved these changes
Nov 4, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When syncing under Savanna it is common for pending LIB to be greater than head.
log_irreversibleupdates the block log and fork db root by the range of blocks from root->LIB when head is in root->LIB. Since LIB can be greater than head this would result inforkdb.fetch_branchreturning an empty branch since searching back from head would not find the LIB causing large delays in the advancement of root.Update
log_irreversibleto fetch branch from root->head when LIB is greater than head and head is in root->head.Resolves #1003